Skip to content

ENH: CI builds against ITK 5.1.0#39

Merged
thewtex merged 11 commits intomasterfrom
itk-5.1-rc02
Apr 30, 2020
Merged

ENH: CI builds against ITK 5.1.0#39
thewtex merged 11 commits intomasterfrom
itk-5.1-rc02

Conversation

@thewtex
Copy link
Copy Markdown
Member

@thewtex thewtex commented Feb 25, 2020

No description provided.

@hjmjohnson
Copy link
Copy Markdown
Member

hjmjohnson commented Feb 26, 2020

@thewtex you may want to compare with changes I needed to make for getting CI to work with ITKPolartransform (Just the last 3 commits) InsightSoftwareConsortium/ITKPolarTransform#15

This also requires changes to: InsightSoftwareConsortium/ITKPythonPackage#137

Hans

@thewtex thewtex force-pushed the itk-5.1-rc02 branch 2 times, most recently from 023d9f3 to 8b7c963 Compare March 5, 2020 14:25
@thewtex thewtex changed the title ENH: CI builds against ITK 5.1 RC 2 ENH: CI builds against ITK 5.1 RC 3 Apr 2, 2020
@thewtex thewtex changed the title ENH: CI builds against ITK 5.1 RC 3 ENH: CI builds against ITK 5.1.0 Apr 27, 2020
@romangrothausmann
Copy link
Copy Markdown
Member

romangrothausmann commented Apr 28, 2020

Looks good, many thanks for all your work on this.
However it is not clear to me why the CI builds here succeed while my manual debug builds still fail even when using ITK-5.1.0 (https://gitlab.com/romangrothausmann/elastix_scripts/-/jobs/530072390) as already reported for ITK-5.1rc03 (#40 (comment)).

@thewtex
Copy link
Copy Markdown
Member Author

thewtex commented Apr 28, 2020

The Azure Pipelines builds did not start :-(, so we do not know their status, yet. I am looking into GitHub Actions instead.

This is building with a branch of elastix on my folk. Once I have verified that the build issues are addressed across platforms, I will push them upstream.

@thewtex
Copy link
Copy Markdown
Member Author

thewtex commented Apr 30, 2020

CI is not starting, but I am going to merge and see if it start on master. Builds succeed locally.

@thewtex thewtex merged commit 45274fc into master Apr 30, 2020
@thewtex thewtex deleted the itk-5.1-rc02 branch April 30, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thewtex @hjmjohnson @romangrothausmann @dzenanz